New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to clarify some points for Vim beginners. #50
Conversation
Make surround.vim more approachable to newer or less knowledgeable Vim users while at the same retaining a README that is not too verbose. - Break examples up into a few sections - Add headers to label these sections - Assume less about skill level of the reader
Any reason you deleted the trailing Other than that, this looks solid! |
No reason other than it seems to work fine without the trailing |
README.markdown
Outdated
<q>Hello world!</q> | ||
|
||
When dealing with existing HTML or XML tags, we don't have to type | ||
out the whole tag, just use the `t` (till). So, to go full circle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The t
used in the cst"
on the next line does not refer Vim’s built-in “till” command, it refers to vim-surround’s tag surround target (see :help surround-targets
).
Maybe something like this:
just use
t
to refer to the immediately surrounding tag pair. So, to go full circle,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, yes, that is better. Updated.
@namick It seems like the same number of keystrokes either way. Both If you want to go with Enter instead of Overall, it seems simpler to just keep the |
README.markdown
Outdated
Now with the cursor on "Hello", press `ysiw]` (`iw` is a text object). | ||
#### Surround a text object | ||
|
||
Now with the cursor on the word "Hello", select the word and surround |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to avoid saying “select” here since that might make the user think of Vim’s visual or select modes.
Maybe just delete the phrase “select the word and”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
@ChrisJohnsen thanks for this. I only skimmed. |
@namick either |
@tpope for some reason I didn't get that the ending |
@ChrisJohnsen thanks for all your help with this. I implemented your suggestions. Let me know if you notice anything else. Also, thanks for alerting me to the surround.txt file. Here I am editing documentation without first reading the real documentation. :-) |
Since I don't seem to be the only one who didn't find the proper documentation in |
Hi Tim, thanks for all your work with Vim and Ruby!
As I continue down the road toward Vim understanding I sometimes need to teach something to really understand it myself. I decided to update the README here as an exercise to understand what can be done with Vim better. If you do decide to pull this commit, please double check that my changes are actually accurate.
From the commit:
Make surround.vim more approachable to newer or less
knowledgeable Vim users while at the same retaining a
README that is not too verbose.