Fixed javadoc errors

torakiki · Oct 25, 2014 · 3e36c7f · 3e36c7f
1 parent 6ffaade
commit 3e36c7f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 16 deletions.
diff --git a/pdfsam-fx/src/main/java/org/pdfsam/ui/commons/SetDestinationRequest.java b/pdfsam-fx/src/main/java/org/pdfsam/ui/commons/SetDestinationRequest.java
@@ -48,8 +48,8 @@ public boolean isFallback() {
 
     /**
      * @param footprint
-     * @param the
-     *            module requesting
+     * @param module
+     *            the module requesting
      * @return a request to set the destination for the task to the given file
      */
     public static SetDestinationRequest requestDestination(File footprint, String module) {
@@ -59,8 +59,8 @@ public static SetDestinationRequest requestDestination(File footprint, String mo
 
     /**
      * @param footprint
-     * @param the
-     *            module requesting
+     * @param module
+     *            the module requesting
      * @return a request to set the destination as fallback for the task to the given file
      */
     public static SetDestinationRequest requestFallbackDestination(File footprint, String module) {

diff --git a/pdfsam-gui/src/main/java/org/pdfsam/ui/log/TextAreaAppender.java b/pdfsam-gui/src/main/java/org/pdfsam/ui/log/TextAreaAppender.java
@@ -26,7 +26,6 @@
 
 import javafx.application.Platform;
 
-import javax.annotation.PostConstruct;
 import javax.inject.Inject;
 import javax.inject.Named;
 
@@ -42,21 +41,21 @@
 import ch.qos.logback.core.AppenderBase;
 
 /**
- * A Logback appender that dispatch the log event as a {@link LogMessageEvent} after the message has been formatted.
+ * A Logback appender appending log messages to a {@link LogListView}.
  * 
  * @author Andrea Vacondio
  * 
  */
 @Named
 public class TextAreaAppender extends AppenderBase<ILoggingEvent> {
 
-    @Inject
+    private LogListView logListView;
     private PatternLayoutEncoder encoder;
-    @Inject
-    public LogListView logListView;
 
-    @PostConstruct
-    public void init() {
+    @Inject
+    TextAreaAppender(LogListView logListView, PatternLayoutEncoder encoder) {
+        this.logListView = logListView;
+        this.encoder = encoder;
         LoggerContext loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory();
         encoder.setContext(loggerContext);
         encoder.start();
@@ -84,10 +83,10 @@ private void doAppendMessage(String message, ILoggingEvent event) {
                         logListView.appendLog(LogLevel.toLogLevel(event.getLevel().toInt()), scanner.nextLine());
                     }
                 }
+                if (event.getLevel().isGreaterOrEqual(Level.ERROR)) {
+                    eventStudio().broadcast(new ErrorLoggedEvent());
+                }
             });
-            if (event.getLevel().isGreaterOrEqual(Level.ERROR)) {
-                Platform.runLater(() -> eventStudio().broadcast(new ErrorLoggedEvent()));
-            }
         }
     }
 

diff --git a/pdfsam-gui/src/test/java/org/pdfsam/ui/log/TextAreaAppenderTest.java b/pdfsam-gui/src/test/java/org/pdfsam/ui/log/TextAreaAppenderTest.java
@@ -65,7 +65,7 @@ public class TextAreaAppenderTest {
     static class Config {
         @Bean
         public TextAreaAppender victim() {
-            return new TextAreaAppender();
+            return new TextAreaAppender(view(), encoder());
         }
 
         @Bean

diff --git a/pdfsam-service/src/main/java/org/pdfsam/pdf/PdfLoadController.java b/pdfsam-service/src/main/java/org/pdfsam/pdf/PdfLoadController.java
@@ -68,7 +68,6 @@ public void close() {
      * Request to load a collection of documents
      * 
      * @param event
-     * @throws InterruptedException
      */
     @EventListener
     public void request(PdfLoadRequestEvent<? extends PdfDocumentDescriptor> event) {