Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite, works. #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Testsuite, works. #339

wants to merge 1 commit into from

Conversation

cheako
Copy link

@cheako cheako commented Aug 31, 2017

I'm not sure why tor2web exits, it could be that it doesn't like the self signed cert.

@cheako
Copy link
Author

cheako commented Sep 11, 2017

The C version works as an echo server, a milestone past the Python version.
https://travis-ci.org/cheako/tor2web/builds/274155883#L935

@cheako
Copy link
Author

cheako commented Sep 13, 2017

It's important to get this working so that behavior with the C implementation can easily be compared. This will direct development, ensuring the work being done is done correctly. Currently the C code is being written against my best guess.

I'd like to have more awareness about what Tor2web actually does.

@NSkelsey
Copy link
Contributor

Hey @cheako, from my understanding of the Tor2Web codebase there are no unittests written for the project. The best you can do to interpret proper functionality is run a tor2web node and examine the results.

With that said, I think that putting together a set of curl tests against the implementation would be super helpful. python requests would also be a great resource for unittest tor2web functionality

@cheako
Copy link
Author

cheako commented Sep 28, 2017

@NSkelsey In trying to run a tor2web instance but it exits prior to fielding any requests, there is no indication as to why. Instead of doing things by hand I wrote, or rather reused, a script for doing this. This way testing can easily be repeated, by anyone.

Please try and identify why this script fails to start tor2web while running on travis.ci, or let me know if it does start and link to your test output.

@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@a325583). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #339   +/-   ##
=========================================
  Coverage          ?   57.17%           
=========================================
  Files             ?       15           
  Lines             ?     2669           
  Branches          ?        0           
=========================================
  Hits              ?     1526           
  Misses            ?     1143           
  Partials          ?        0
Impacted Files Coverage Δ
tor2web/t2w.py 60.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a325583...cdd4823. Read the comment docs.

@cheako cheako changed the title Testsuite, fails to start tor2web. Testsuite, works. Oct 10, 2017
@evilaliv3 evilaliv3 force-pushed the master branch 2 times, most recently from 49963c6 to 3c31643 Compare May 14, 2019 21:44
@evilaliv3 evilaliv3 force-pushed the master branch 10 times, most recently from 7920f58 to bf26275 Compare October 1, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants