Color relative due date based on remaining time #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable at first blush. I have limited access for a bit - I'll address it when I'm more online. |
|
Note the test failures. |
|
Yeah I know only 3.10 because of the match statement. |
|
Changes need to be compatible with supported Python versions. I'll leave the PR open in the interim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm quite happy with how this turned out and it passes all the tests, but there needs to be some unit tests for this which unfortunately I don't have time for. I've used this on my own set of todos and it works just fine.
Fixes #299
EDIT: I forgot to mention that this code only works on Python 3.10 and above.