-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Add counts for projects and contexts #249
base: master
Are you sure you want to change the base?
Conversation
@bram85 First of all, thanks a ton for such a nice project! I am not sure if you'd be interested in an addition like this one, but I would very much appreciate it. I am also not sure what the preferred output format of these "counts" should be, so I am happy to refactor this to meet the overall vision of Thanks! |
facacf7
to
56b1954
Compare
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 96.98% 96.96% -0.02%
==========================================
Files 51 51
Lines 2915 2962 +47
Branches 454 472 +18
==========================================
+ Hits 2827 2872 +45
Misses 61 61
- Partials 27 29 +2
Continue to review full report at Codecov.
|
* Add `projects_counts` and `contexts_counts` functions to `TodoListBase` that return a dict of all projects/contexts along with their counts. * Add command line flags to `lsproj` and `lscont` that allow project/contexts to be listed with their respective counts, while also being sorted by this count. * Add tests for all new functionality. Signed-off-by: mr.Shu <mr@shu.io>
56b1954
to
f007b1b
Compare
@bram85 Sadly, I was not able to increase coverage of the changes I introduced here, despite trying fairly hard. If you'd have any pointers as to how to do that, please let me know -- I'll gladly do that. Thanks! |
@bram85 Would you happen to have a quick moment to take a look at this? Thanks! |
@bram85 Please feel free to let me know what I can do to move this forward. Thanks! |
A couple of comments:
Beyond that, as long as it is optional, I could see adding this. |
Add
projects_counts
andcontexts_counts
functions toTodoListBase
that return a dict of all projects/contexts along withtheir counts.
Add command line flags to
lsproj
andlscont
that allowproject/contexts to be listed with their respective counts, while also
being sorted by this count.
Add tests for all new functionality.
Signed-off-by: mr.Shu mr@shu.io