Colorblock in console #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruwek
force-pushed
the
colorblock-in-console
branch
from
3ee2ff0
to
d74e23e
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 96.86% 95.81% -1.05%
==========================================
Files 51 52 +1
Lines 2871 2727 -144
Branches 443 430 -13
==========================================
- Hits 2781 2613 -168
- Misses 61 86 +25
+ Partials 29 28 -1
Continue to review full report at Codecov.
|
Previously topydo.lib.Color instances were agnostic of their purpose. Each instance could be used to provide foreground or background color. From now on this decision should be made at the initialization time by passing additional boolean argument (True for background, and False for foreground) to the constructor. Since we use that class mostly for changing foreground colors, False = foreground is assumed by default when no such argument is passed. This changes the way we're using Color.as_ansi() method - it doesn't accept additional p_background argument now.
ListFormatParser uses now non-printable bell character as a placeholder for color-block to avoid confusion with normal spaces and conversion to spaces happens right after applying all the colors by PrettyPrinterColorFilter. Progress colors are now also calculated by PrettyPrinterColorFilter and stored in TopydoString along with the other colors.
mruwek
force-pushed
the
colorblock-in-console
branch
from
d74e23e
to
eaf2b0d
Compare
|
I personally don't do much with column mode. Before diving into this, please let me know if you are interested in pursuing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (in a bit hacky way) #134
This PR is simply rebase of #126 against master branch. I'm pushing it here to provide a temporary solution and some "food for thougt" about the issue. It probably won't be merged in it's current shape so use at your own risk :)