fix(Select): issues after upgrade to MUI v4 #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenchyk
force-pushed
the
FX-373-fix-native-select
branch
from
0a33685
to
f1426f0
Compare
|
|
denieler
approved these changes
Aug 14, 2019
denieler
reviewed
Aug 15, 2019
| @@ -20,7 +20,6 @@ declare module '@material-ui/core/styles/createTypography' { | |||
| } | |||
|
|
|||
| const typography = { | |||
| useNextVariants: true, | |||
MilosMosovsky
approved these changes
Aug 15, 2019
havenchyk
force-pushed
the
FX-373-fix-native-select
branch
from
3dc208c
to
40bc214
Compare
havenchyk
changed the title
|
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
denieler
pushed a commit
that referenced
this pull request
Aug 19, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
MilosMosovsky
pushed a commit
that referenced
this pull request
Aug 23, 2019
conf
pushed a commit
that referenced
this pull request
Aug 23, 2019
# [3.0.0](v2.27.1...v3.0.0) (2019-08-23) ### Bug Fixes * **Accordion:** fix Accordion styles ([#592](#592)) ([c2636b9](c2636b9)) * **Accordion:** fix an issue with no children rendered ([b9d198e](b9d198e)) * **CssBaseline:** [FX-368] Use our own css baseline ([#595](#595)) ([bf9052c](bf9052c)) * **Grid:** divide Picasso grid spacing according to MUI ([#586](#586)) ([41b9783](41b9783)) * **paper:** fix default text color ([#594](#594)) ([5522976](5522976)) * **Select:** issues after upgrade to MUI v4 ([#590](#590)) ([7c34698](7c34698)) * **Slider:** [FX-378] Move Slider from lab to core ([#596](#596)) ([58e33b9](58e33b9)) * **Table:** adjust cell paddings ([#591](#591)) ([550d901](550d901)) * **Tabs:** after upgrade to v4 ([#593](#593)) ([07dcef8](07dcef8)) * fix disabled state for Checkbox and Radio ([#587](#587)) ([bc73cea](bc73cea)) * **Tooltip:** issues after upgrade to v4 ([#581](#581)) ([65676e0](65676e0)) * **Typography:** fix typography, baseline visual issues ([#585](#585)) ([68e8aec](68e8aec)) ### chore * **TextField:** remove deprecated props and rename to Input ([#606](#606)) ([1d63602](1d63602)) * rename `justifyContent` prop in Grid to match Container ([#600](#600)) ([8da9a02](8da9a02)) * **Icon:** delete deprecated icon components ([#598](#598)) ([b37be08](b37be08)) * **Icon:** remove deprecated prop `size` from icons ([#599](#599)) ([033a5ac](033a5ac)) ### Features * [FX-377] Forward refs for all components ([#612](#612)) ([677af2e](677af2e)) * [FX-377] Proxy ref from forwardRef to FileInput ([#621](#621)) ([54668a3](54668a3)) * upgrade MUI to v4 ([29d14bd](29d14bd)) ### BREAKING CHANGES * **TextField:** TextField component to Input * **Slider:** Slider component has been moved from `@toptal/picasso/lab` to `@toptal/picasso` * rename `justify` prop in `Grid` to `justifyContent` * **Icon:** remove deprecated prop `size` from icons * **Icon:** icon components deprecated in v2 have been fully removed in v3. To obtain support migrating these components, check: https://toptal-core.atlassian.net/wiki/x/boACG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-373
Description
The structure of the select has been changed mui/material-ui#16137, so styles should be fixed
How to test
Review
propsin component with documentationexamplesfor component