Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4583] Migrate Menu #4257

Merged
merged 16 commits into from
May 17, 2024
Merged

[FX-4583] Migrate Menu #4257

merged 16 commits into from
May 17, 2024

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Apr 22, 2024

FX-4583

Description

Migrate to TailwindCSS

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama self-assigned this Apr 22, 2024
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: def8f8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@toptal/picasso-drawer Major
@toptal/picasso-account-select Major
@toptal/picasso-autocomplete Major
@toptal/picasso-select Major
@toptal/picasso-page Patch
@toptal/picasso-modal Major
@toptal/picasso Major
@toptal/picasso-forms Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-date-select Patch
@toptal/picasso-prompt-modal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama TomasSlama changed the base branch from master to feature/tw-modal April 22, 2024 09:54
@toptal-devbot
Copy link
Collaborator

toptal-devbot commented Apr 22, 2024

⚠️ Following packages are missing changesets. Please check if they don't require one.

@toptal/picasso-utils

@TomasSlama TomasSlama changed the base branch from feature/tw-modal to master May 15, 2024 14:17
@TomasSlama TomasSlama changed the base branch from master to feature/tw-modal May 15, 2024 14:17
@TomasSlama TomasSlama marked this pull request as ready for review May 16, 2024 08:23
@TomasSlama TomasSlama requested a review from a team as a code owner May 16, 2024 08:23
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama TomasSlama requested a review from sashuk May 16, 2024 13:25
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tried interactions locally in http://localhost:9001/?path=/story/components-menu--menu and http://localhost:9001/?path=/story/forms-select--select and compared with https://picasso.toptal.net/, code looks good too, amazing job!

@sashuk sashuk requested a review from a team May 16, 2024 13:41
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well! There are some visual changes in Happo that might or might not be related, might be worth looking into.

@TomasSlama TomasSlama merged commit ff1aab3 into feature/tw-modal May 17, 2024
13 of 14 checks passed
@TomasSlama TomasSlama deleted the fx-4583-menu branch May 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants