New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): render disabled button as span #1540
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+15.4 KB
...es/picasso/src/Button/__image_snapshots__/button-disabled-with-tooltip-snap.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
40 changes: 40 additions & 0 deletions
40
packages/picasso/src/Button/story/DisabledWithTooltip.example.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import React from 'react' | ||
import { Container, Button, Tooltip, Typography } from '@toptal/picasso' | ||
import { useNotifications } from '@toptal/picasso/utils' | ||
|
||
const Example = () => { | ||
const { showSuccess } = useNotifications() | ||
const handleClick = () => showSuccess('I was clicked') | ||
|
||
return ( | ||
<div> | ||
<Typography variant='heading' size='small'> | ||
Disabled button with the tooltip: | ||
</Typography> | ||
<Container top='small' bottom='large'> | ||
<Button onClick={handleClick}>Enabled</Button> | ||
<Tooltip content='Action is disabled'> | ||
<Button disabled onClick={handleClick}> | ||
Disabled With Tooltip | ||
</Button> | ||
</Tooltip> | ||
</Container> | ||
|
||
<Typography variant='heading' size='small'> | ||
Disabled button with the tooltip inside the button group: | ||
</Typography> | ||
<Container top='small'> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add some text above each of these examples so it's more obvious that the top example is two buttons and the bottom is a button group |
||
<Button.Group> | ||
<Button onClick={handleClick}>Enabled</Button> | ||
<Tooltip content='Action is disabled'> | ||
<Button disabled onClick={handleClick}> | ||
Disabled With Tooltip | ||
</Button> | ||
</Tooltip> | ||
</Button.Group> | ||
</Container> | ||
</div> | ||
) | ||
} | ||
|
||
export default Example |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -188,10 +188,14 @@ page | |
.addExample('Button/story/Basic.example.jsx', 'Basic') | ||
.addExample('Button/story/Variants.example.jsx', 'Variants') | ||
.addExample('Button/story/States.example.jsx', 'States') | ||
.addExample('Button/story/Disabled.example.jsx', { | ||
.addExample('Button/story/Disabled.example.tsx', { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
||
title: 'Disabled', | ||
description: 'The button shows that currently unable to be interacted with' | ||
}) | ||
.addExample( | ||
'Button/story/DisabledWithTooltip.example.tsx', | ||
'Disabled with tooltip' | ||
) | ||
.addExample('Button/story/Sizes.example.jsx', 'Sizes') | ||
.addExample('Button/story/FullWidth.example.jsx', 'Full width') | ||
.addExample('Button/story/IconButtons.example.jsx', 'Button with Icon') | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this eslint disable necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason precommit hook started complaining to me yesterday, maybe it started happening when Davinci dependency version was bumped recently, not sure TBH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty strange, can you please figure out why this error started to happen?