Support k8s 1.29 #910
Merged
Support k8s 1.29 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshipp
force-pushed
the
support-k8s-1.29
branch
2 times, most recently
from
afc568b
to
a688265
Compare
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
satoru-takeuchi
approved these changes
May 13, 2024
daichimukai
reviewed
May 15, 2024
| @@ -1524,6 +1525,7 @@ var _ = Describe("client", func() { | |||
| svc.Name = configmapName | |||
| svc.Namespace = configmapNamespace | |||
| svc.Spec = corev1.ServiceSpec{ | |||
| Type: corev1.ServiceTypeLoadBalancer, | |||
There was a problem hiding this comment.
Note: From k8s 1.29, a Service must have LoadBalancer as its spec.type to set status.loadBalancer.
Setting the status.loadBalancer of a Service whose spec.type is not LoadBalancer was previously allowed, but any update to the metadata or spec would wipe that field. Setting this field is no longer permitted unless spec.type is LoadBalancer.
daichimukai
reviewed
May 15, 2024
| @@ -142,7 +142,7 @@ var _ = Describe("LogicalVolume controller", func() { | |||
| AccessModes: []corev1.PersistentVolumeAccessMode{ | |||
| corev1.ReadWriteOnce, | |||
| }, | |||
| Resources: corev1.ResourceRequirements{ | |||
| Resources: corev1.VolumeResourceRequirements{ | |||
There was a problem hiding this comment.
Note:
Go API: the ResourceRequirements struct was replaced with VolumeResourceRequirements for use with volumes.
daichimukai
approved these changes
May 15, 2024
|
Hi Team, could you please advise if you are planning to release a new tag with these changes soon? |
|
Our release cycle is monthly, I expect the new release to ship in the 1st week of June. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #793