feat!: Use lvmdEmebbed by default

[ryanfaircloth]

BREAKING CHANGE: Using lvmdEmbedded by default reduces pod count per host by 1 and causes no loss of functionality. Users are only impacted if they have added initicontainers or modified volumes/mounts.

[pluser]

@jakobmoellerdev
The lvmd embedded option has only been in place for a short time.
How long do you think we should wait for stabilization?

[jakobmoellerdev]

In general: I think this PR is safe as Im not changing any business logic and we have e2e tests running for it for all scenarios, pretty sure that this does not cause any functional regressions.

If you want to wait for a broad userbase: lvmd embedded mode will be used in all Openshift TopoLVM installations by default starting with Openshift 4.15 Release which is coming end of next month. After that I suggest waiting 2-3 months so we can report issues upstream. So I suggest putting this on hold for the next quarter

[pluser]

@jakobmoellerdev Thank you for the information.

Personally, I think it is a little early to get solid assurance of safety, so I would like to wait a few more months or so.

@ryanfaircloth Do you have any issues with waiting a few months?

[ryanfaircloth]

@jakobmoellerdev Thank you for the information.

Personally, I think it is a little early to get solid assurance of safety, so I would like to wait a few more months or so.

@ryanfaircloth Do you have any issues with waiting a few months?

I do not I just adopted this via helm chart config