New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support k8s 1.29 #910
Support k8s 1.29 #910
Conversation
afc568b
to
a688265
Compare
Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
@@ -1524,6 +1525,7 @@ var _ = Describe("client", func() { | |||
svc.Name = configmapName | |||
svc.Namespace = configmapNamespace | |||
svc.Spec = corev1.ServiceSpec{ | |||
Type: corev1.ServiceTypeLoadBalancer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: From k8s 1.29, a Service must have LoadBalancer as its spec.type to set status.loadBalancer.
Setting the status.loadBalancer of a Service whose spec.type is not LoadBalancer was previously allowed, but any update to the metadata or spec would wipe that field. Setting this field is no longer permitted unless spec.type is LoadBalancer.
@@ -142,7 +142,7 @@ var _ = Describe("LogicalVolume controller", func() { | |||
AccessModes: []corev1.PersistentVolumeAccessMode{ | |||
corev1.ReadWriteOnce, | |||
}, | |||
Resources: corev1.ResourceRequirements{ | |||
Resources: corev1.VolumeResourceRequirements{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
Go API: the ResourceRequirements struct was replaced with VolumeResourceRequirements for use with volumes.
Hi Team, could you please advise if you are planning to release a new tag with these changes soon? |
Our release cycle is monthly, I expect the new release to ship in the 1st week of June. |
Fix: #793