fix the issue that the session's Close method could be invoked multi times #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…times,and sometimes deletes the new session caused by goroutine SYNC issue
|
There is a possibility that the method is invoked from HandlerService.Handle's defer logic at the same time from different goroutine.
|
felipejfc
requested changes
Apr 23, 2024
| // so we need to make sure two things: | ||
| // 1. ensure the Close method's logic is done only once, for the reason to prevent deleting the new one | ||
| // 2. double check that there isn't a session in the store data before Storing | ||
| for s.pool.GetSessionByUID(uid) != nil { |
There was a problem hiding this comment.
Can we put a timeout here so that this doesn't turn into a dead lock in corner cases?
There was a problem hiding this comment.
Sure, That's great. But I am not sure that how much timeout value we could set, is 30s enough? Or set the loop counter limit directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the framework uses a sync.map and some check logic to prevent the SYNC issue, there is possibility to trigger in some situation.