Correctly handle unmount and remount of toolkit reports #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
78
to
80
| $(`${YNAB_NAVLINK_SELECTOR}, ${YNAB_NAVACCOUNT_SELECTOR}`).on('click', (e) => | ||
| this._removeToolkitReports(e) | ||
| ); |
There was a problem hiding this comment.
I think we need to do
$(`${YNAB_NAVLINK_SELECTOR}, ${YNAB_NAVACCOUNT_SELECTOR}`).on('click', this._removeToolkitReports);or we might add an event listener every time _updateNavigation runs?
There was a problem hiding this comment.
This will attach multiple listeners too. I checked and it seem to be a 'problem' only if user repeatedly clicks on 'Toolkit reports' while they are already open. But anyway I updated, now there will be only one listener at a time
joshmadewell
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (if applicable): #3451 #3446
Explanation of Bugfix/Feature/Modification:
Fixed a couple of issues I missed in previous PRs (#3438 #3315)
Screenshots
If you're adding or changing a feature. Please include screenshots or a video of the feature.