making column checking robust to passing pandas index #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompollard
reviewed
Apr 20, 2018
tableone.py
Outdated
| categorical = self._detect_categorical_columns(data[columns]) | ||
| elif 'pandas.core.indexes' in str(type(categorical)): | ||
| categorical = categorical.get_values() | ||
| elif type(categorical) != list: |
There was a problem hiding this comment.
If someone specifies a single categorical variable as a string (e.g. categorical = 'ICU'), then I think we now ignore their selection and generate the list ourselves. Might be good to catch the string too?
tompollard
force-pushed
the
master
branch
3 times, most recently
from
9ff9874
to
1db34db
Compare
tompollard
force-pushed
the
master
branch
3 times, most recently
from
6f62620
to
fabcd16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix - passing an index object to columns causes an error (e.g.
t1 = tableone(df, columns=df.columns)). Added a check if it's a pandas index data type since it's probably very common to pass it.