Add pyright type checks to GitHub workflow #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompollard
force-pushed
the
tp/pyright_workflow
branch
from
7646117
to
95c55df
Compare
tompollard
force-pushed
the
tp/pyright_workflow
branch
from
95c55df
to
e550f5e
Compare
tompollard
force-pushed
the
tp/pyright_workflow
branch
from
c0175bb
to
c44ee98
Compare
We could probably replace this module with an import at this point. Someone must have implemented somewhere.
tompollard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds pyright to the GitHub workflow to enable continuous type checking. I'm expecting the tests to fail initially. I'll fix the failed tests in a separate branch and then rebase this (at which point hopefully the tests will pass!).