UDP/TCP switch for Discovery and Bootstrap builders #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffer. The current approach does not work well with constrained devices.
data will disappear
Minor edit, not sure if this is actually correct but, what was there wasn't right.
…ld all objects in the collection.
Suggested fix for issue tomp2p#121
Update logic in NATTypeDetection.twoOutOfThreeSame
Agreed, thanks for this pull request!
Update FutureGet class description text
*** buffer overflow detected ***: /usr/lib/jvm/java-7-openjdk-amd64/jre/bin/java terminated ======= Backtrace: ========= /lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x37)[0x7f1928ff6e57] /lib/x86_64-linux-gnu/libc.so.6(+0x108d50)[0x7f1928ff5d50] /usr/lib/jvm/java-7-openjdk-amd64/jre/lib/amd64/libnet.so(Java_java_net_Inet4AddressImpl_getLocalHostName+0x190)[0x7f191cd7a9a0] [0x7f191d012d98]
…ot set, the manual testcases for NAT may randomly fail
Added/Corected comments. Corrected a bug regarding internal ip setup on manual port forwarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UDP/TCP switch for Discovery and Bootstrap builders as discussed previously.
Also corrected a small error in discovery when using manual ports (or setting expectManualForwarding) resulting in the internal IP address to be ignored.
Tested with both TCP and UDP between two distant, NAT'ed nodes. Special discovery cases should be tested.