Force install a py2 compatible version of pandas #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitti2bag depends on pykitti which depends on pandas which deprecated py2 support in 0.24 causing breakage in the docker build. This patch works around this issue by first installing a py2 compatible version of pandas before installing kitti2bag.
amtagrwl
approved these changes
Nov 26, 2019
|
travis failing with same error on master. https://travis-ci.org/tomas789/kitti2bag/builds/610976165?utm_medium=notification&utm_source=github_status |
|
Confirmed this fix for the docker image build |
|
anybody willing to give it a merge? |
|
@amtagrwl thanks for the review. Somehow merge is still blocked? |
|
@LiyouZhou Yeah. Travis CI fails. Could you please confirm that the pull request builds? |
|
@amtagrwl verified today that this pr builds and master is still broken. |
ErikUckert
added a commit
to ErikUckert/kitti2bag
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kitti2bag depends on pykitti which depends on pandas
which deprecated py2 support in 0.24 causing breakage
in the docker build. This patch works around this issue
by first installing a py2 compatible version of pandas
before installing kitti2bag.