Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update time 0.3 and postgres 0.19 #241

Closed
wants to merge 2 commits into from
Closed

Conversation

oherrala
Copy link
Contributor

This PR updates two dependencies: time to version 0.3 (yay!) and postgres to 0.19.

@bradfier
Copy link
Collaborator

Postgres 0.19 requires Rust 1.46 due to depending on rust-lang/rust#49146

Other than bumping some very old dependencies (which I'm 100% on-board with!) does this upgrade buy us anything that would justify increasing our MSRV?

@oherrala
Copy link
Contributor Author

@bradfier Oh, I didn't know about the version dependency.

But for me, the master branch doesn't build any more so I chose the easy way out by just updating the dependency:

% cargo test
    Updating crates.io index
error: failed to select a version for the requirement `hmac = "^0.1"`
candidate versions found which didn't match: 0.11.0, 0.10.1, 0.10.0, ...
location searched: crates.io index
required by package `postgres-protocol v0.3.0`
    ... which is depended on by `postgres v0.15.2`
    ... which is depended on by `rouille v3.2.1 (/Users/oherrala/tmp/rouille)`

Is the postgres really needed at all? It feels like massive dependency to have for testing one example.

@bradfier
Copy link
Collaborator

But for me, the master branch doesn't build any more so I chose the easy way out by just updating the dependency:

Thanks for this, it's frustrating that the version of HMAC that we depended on has been yanked, such is the state of dependencies in Rust I suppose!

Is the postgres really needed at all? It feels like massive dependency to have for testing one example.

That's a fair point, I'd accept a PR that removes it (maybe swapping for some equivalent but lighter DB connector), or replaces that documentation example with something equivalent.

@bradfier
Copy link
Collaborator

bradfier commented Sep 1, 2021

@oherrala thanks for this! I ended up bumping the MSRV as debian dropped 1.41 and merged your updates as 8075ccc

@bradfier bradfier closed this Sep 1, 2021
@oherrala
Copy link
Contributor Author

oherrala commented Sep 1, 2021

@bradfier Thanks!

@oherrala oherrala deleted the updates branch September 1, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants