Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[musicbrainz]Use disambiguation as album name if available #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theli-ua
Copy link
Contributor

Other options would be to use
Title (disambiguation)
or
Title disambiguation

Though this one works perfectly fine for me for the following case:
https://bugs.tomahawk-player.org/browse/TWK-2123

(3 albums "Crystal Castles")

@muesli
Copy link
Member

muesli commented Sep 29, 2015

Hm, not sure I understand why this helps / how this is supposed to work.

@dschmidt
Copy link
Member

ping @theli-ua

@theli-ua
Copy link
Contributor Author

It helps in the case mentioned because artist mentioned have 3 releases with the same "title" - "Crystal Castles" , using disambiguation, when we try to receive tracklist it matches to a corresponding album correctly.

Though this probably needs more testing or just needs to be handled differently (like have ability to select specific releases from musicbrainz, etc ... this is a problem even for the variants of the same release)

@dschmidt
Copy link
Member

Aaah, so it makes albums show up as "Something (Album)" vs. "Something (Single)" e.g.?

@dschmidt
Copy link
Member

This might fuck with data in the database, @muesli knows this stuff better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants