Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better output on toltecctl uninstall #692

Open
wants to merge 30 commits into
base: testing
Choose a base branch
from
Open

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented May 10, 2023

  • Provide output right at the end if a removal fails due to a preremove script. That way, the user can double-check the output to see if there is something bad. For example, kernelctl failed to revert to the stock kernel.
  • Make changes to toltecctl to get closer to allowing the installation to be somewhere other than /opt, not that entware supports that yet.
  • Make toltecctl uninstall handle unexpected states like partial uninstall a lot better.
  • Backup toltecctl on uninstall to continue allowing users to uninstall if something goes wrong.
  • Fix issues with installdepends not properly being set for several packages that caused them to be removed after their dependencies were removed, thus breaking uninstall.

Provide output right at the end if a removal fails due to a preremove script. That way, the user can double-check the output to see if there is something bad. For example, kernelctl failed to revert to the stock kernel.
@Eeems Eeems added the packages Add or improve packages of the repository label May 10, 2023
@Eeems Eeems requested a review from matteodelabre May 10, 2023 18:29
@Eeems Eeems marked this pull request as ready for review May 10, 2023 18:33
@Eeems Eeems added this to the 2023-W31 merge window milestone Jul 26, 2023
@rM-self-serve
Copy link
Contributor

I created a test package that will fail during preremove.
Do you have any tips on restoring /opt after uninstalling?

@Eeems
Copy link
Member Author

Eeems commented Dec 8, 2023

I created a test package that will fail during preremove.
Do you have any tips on restoring /opt after uninstalling?

Uninstall removes /opt, which is actually /home/root/.entware. you will have to install again with bootstrap. If you want to avoid doing so, you can copy the .entware folder before doing the uninstall, rename the copy to .entware after uninstalling and then re-enable.

Jayy001
Jayy001 previously approved these changes May 31, 2024
@Eeems

This comment was marked as resolved.

@Eeems Eeems requested a review from Jayy001 June 2, 2024 18:32
@Eeems

This comment was marked as resolved.

@Eeems

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants