New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Slack integration #2247
Draft
JanCizmar
wants to merge
142
commits into
main
Choose a base branch
from
slack-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Slack integration #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack-integration # Conflicts: # backend/data/src/main/kotlin/io/tolgee/constants/Message.kt
…bility and event-specific notifications.
…to prevent duplicate event notifications. Messages now update when translations or states change within 2 hours.
…zhosov/slack-integration # Conflicts: # backend/data/src/main/kotlin/io/tolgee/constants/Message.kt # backend/data/src/main/kotlin/io/tolgee/model/Project.kt # backend/data/src/main/resources/db/changelog/schema.xml # webapp/src/service/apiSchema.generated.ts
…zhosov/slack-integration
…zhosov/slack-integration # Conflicts: # backend/data/src/main/kotlin/io/tolgee/constants/Message.kt # webapp/src/service/apiSchema.generated.ts
fix: Minor changes for Ivan's PR
…olgee-platform into ivanmanzhosov/slack-integration
…hosov/slack-integration
…#2284) I have added - endpoint which returns data for activity in paginated form - filter option, that allows to filter translations by provided revision id (only keys mentioned in revision are returned) **Why this?** - When user executes operation modifying many columns, there is no way in the system where you can check what specifically was changed. - When operations are executed, users are notified in slack and can usually can get to the platform to key edition view by clicking a button in the Slack message. This works fine when single key is affected by the operation. However, we need to provide similar path when larger amount data is imported so user is redirected to the Activity view and from there, they're able to go to translations view. This is blocking the Slack integration, so we need simple solution before we implement the ultimate activity grouping and notification system. @stepan662 can you please add frontend for the Activity view? This should be pretty the same as it is now, we just need to add pagination @ZuzanaOdstrcilova can you create a UI proposal of how it should look in the translations view - IMO, we should display this filter information super clearly, since this is not a standard filter, which is selectable from filter menu - We can show - the date / time of the activity, the autor, and the activity type (e.g., key creation, translations update, import, etc) - Let's discuss it Monday. @huglx Can you please sync with Stepan, so we redirect users from Slack to the activity when import is executed? Thanks!
No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews. |
…that another language was changed
…hosov/slack-integration # Conflicts: # backend/data/src/main/resources/db/changelog/schema.xml
…e tag error handling
chore: New tests for Slack integration
…design-updates fix: new updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.