Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Single step import & Export enhancements for CLI #2142

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

JanCizmar
Copy link
Contributor

No description provided.

Base automatically changed from jancizmar/formats-support to visual-editor-and-formats-support February 27, 2024 08:39
Base automatically changed from visual-editor-and-formats-support to main March 5, 2024 16:45
Copy link
Contributor

github-actions bot commented Apr 6, 2024

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 6, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Apr 20, 2024
@JanCizmar JanCizmar reopened this Apr 23, 2024
@github-actions github-actions bot removed the stale label Apr 24, 2024
@JanCizmar JanCizmar force-pushed the jancizmar/single-step-import branch from 3cc7b5a to e5ae12c Compare April 24, 2024 15:10
@JanCizmar JanCizmar marked this pull request as draft April 29, 2024 11:57
@JanCizmar JanCizmar force-pushed the jancizmar/single-step-import branch from 343a3f9 to be24cfc Compare April 29, 2024 12:04
@tolgee tolgee deleted a comment from restack-app bot May 3, 2024
Copy link

restack-app bot commented May 3, 2024

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

@JanCizmar JanCizmar marked this pull request as ready for review May 6, 2024 11:46
@JanCizmar JanCizmar requested a review from stepan662 May 6, 2024 11:46
@JanCizmar JanCizmar marked this pull request as draft May 6, 2024 11:49
@JanCizmar JanCizmar linked an issue May 6, 2024 that may be closed by this pull request
@JanCizmar JanCizmar changed the title feat: Single step import feat: Single step import & export enhancements for CLI May 6, 2024
@JanCizmar JanCizmar changed the title feat: Single step import & export enhancements for CLI feat: Single step import & Export enhancements for CLI May 6, 2024
@JanCizmar JanCizmar force-pushed the jancizmar/single-step-import branch from e717610 to b3917c6 Compare May 6, 2024 12:28
@JanCizmar
Copy link
Contributor Author

Requirements for the CLI:

Flow with Tolgee SDK:

  • adding a new key with tag "draft" (or "draft-feature-name") (part of SDK)
  • when releasing, find keys in the code
    • mark all existing as "production" and remove "draft"
    • mark all that were "production" before and are not now as "deprecated" (or "deprecated-in-X.X.X")

Flow without Tolgee SDK:

  • push english translations - all non-existant keys marked as "draft"
  • ... rest is the same
Possible syntax

$ tolgee push ... --tag-new "draft"
$ tolgee tag --filter "extracted" --add "production" --remove "draft"
$ tolgee tag --filter "tag:production & not:extracted" --add "deprecated"

@stepan662
Copy link
Contributor

Issue with Apple "STRINGS" format on single-step-import, not accepting the file which was previously exported from the platform (Throwing 500).

Also it would be nice, if we'd merged "STRINGS" and "STRINGSDICT" into "APPLE_STRINGS_STRINGSDICT" as it is in export, so it can be defined on one place in the config.

@stepan662
Copy link
Contributor

stepan662 commented May 14, 2024

Seems like filterTagNotIn in export works somehow weirdly - it exports only the namespace, where the tag is and doesn't filter by it.

@stepan662
Copy link
Contributor

For the tag command to work, it requires a new parameter filterKeysNot, which will select oposite of listed keys. That way, we can find deprecated keys like this:

tolgee tag --filter-not-extracted --filter-tag production --tag-filtered deprecated

There should also be possibility to mark newly created keys as draft, for which we need parameter in the single-step-import - something like tagCreatedKeys, with list of tags that should be added to newly created keys.

@JanCizmar JanCizmar force-pushed the jancizmar/single-step-import branch from 470be61 to d167eda Compare May 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export -> Filtering by tag
2 participants