Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cockroach DB support #1405

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

JanCizmar
Copy link
Contributor

@JanCizmar JanCizmar commented Oct 22, 2022

There are some issues which have to be fixed:

@JanCizmar JanCizmar linked an issue Oct 22, 2022 that may be closed by this pull request
@cyyynthia
Copy link
Collaborator

Cockroach has a bunch of recommendations for CI envs, it may be interesting in looking into them to speed up CI which seem awfully slow looking at GitHub action reports

https://www.cockroachlabs.com/docs/stable/local-testing.html

@JanCizmar
Copy link
Contributor Author

@JanCizmar
Copy link
Contributor Author

TM works fine with CRDB v22.2-beta.4!

@wodka
Copy link

wodka commented Dec 14, 2022

we are running it now with CRDB v22.2.0 :) looking forward to see this merged, thanks again for implementing it!

@JanCizmar
Copy link
Contributor Author

JanCizmar commented Dec 14, 2022

Hey! I still have to fix all the tests 😢 I've updated the crdb to the stable, so lets see.

@wodka
Copy link

wodka commented Dec 14, 2022

XD sry, completely missed that. Perhaps I will find time towards the end of the week to help.

e2e/docker-compose.yml Outdated Show resolved Hide resolved
backend/app/build.gradle Outdated Show resolved Hide resolved
@JanCizmar JanCizmar force-pushed the jancizmar/cockroach-db-compatibility branch from 36f74e9 to 866f2af Compare January 4, 2023 13:22
@JanCizmar
Copy link
Contributor Author

JanCizmar commented Jan 4, 2023

UPDATE: I fixed the tests in this repo. However, we have another private repo, where we work on pricing/billing section of the app. And in this repo I cannot get it working, since there is some weird stuff related to transactions happening.

UPDATE 2: I fixed the private repo issues, but now there is 7 failing tests in this repo. I am out of time budget I want to invest to this, so I will try again later again.

If someone would like to contribute in this, the tests can be run with cockroachDB with SPRING_PROFILES_ACTIVE=cockroach

SPRING_PROFILES_ACTIVE=cockroach ./gradlew test

Single test can be run and debugged in IntelliJ Idea CE or Ultimate. Just use gradle runner and set the environment env.

image

Anyway...

We are currently going to move our production to MS Azure and their Cosmos for Postgres, since that is more stable for now. Will consider Cockroach later, when we're stabilized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 8, 2023
@JanCizmar JanCizmar added enhancement New feature or request and removed stale labels Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 8, 2023
@Martin005 Martin005 removed the stale label Apr 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label May 9, 2023
@github-actions github-actions bot removed the stale label May 21, 2023
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 21, 2023
@JanCizmar JanCizmar removed the stale label Jun 21, 2023
@JanCizmar
Copy link
Contributor Author

@stepan662 Why it went stale? It's tagged as enhancement!

@Martin005
Copy link
Contributor

@JanCizmar Because on PRs, it checks only for "keep-open" label. On issues, it checks "roadmap item, enhancement, keep-open, bug".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep-open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CockroachDB
4 participants