Change request holder filter configuration #793
Conversation
bennetelli
changed the title
|
ich traue dem Braten irgendwie noch nicht so recht. Lasse den PR mal offen und denke nochmal drüber nach ob das so erwartungskonform ist. |
| @@ -255,7 +255,6 @@ public TogglzDialect togglzDialect() { | |||
| @Configuration | |||
| @ConditionalOnClass({OncePerRequestFilter.class}) | |||
| @ConditionalOnMissingBean(HttpServletRequestHolderFilter.class) | |||
| @ConditionalOnProperty(prefix = "togglz.web", name = "request-holder-filter", havingValue = "true") | |||
There was a problem hiding this comment.
This is acutally the place I would add this:
@ConditionalOnProperty(prefix = "togglz.web", name = "request-holder-filter", havingValue = "true", matchIfMissing = true)
This would make the filter enabled per default, so all config changes made by you in this PR in the samples project are fine, but we would probably need to set the config value to false for the war sample application?
If you could think about this topic next, that would be call. |
#760