Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix typo in pull request template #420

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Aug 16, 2023

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

ShellCheck lints code. shdoc is something that would format code, but I see that using it modifies most of the script.

Also just a heads up, I noticed that in CODE_OF_CONDUCT.md, the contact email under "## Enforcement" still shows TBD@TBD.tld.

Copy link
Member

@karbassi karbassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@karbassi karbassi merged commit fd753c6 into todotxt:master Aug 16, 2023
2 checks passed
@hyperupcall hyperupcall deleted the hyperupcall-fix-typo branch August 17, 2023 03:43
andreabenini added a commit to andreabenini/todo.txt-cli that referenced this pull request Sep 11, 2023
style: Fix typo in pull request template (todotxt#420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants