Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing MacOS 11 tests #415

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jun 30, 2023

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

@inkarkat I finally made the hack working! Please merge, then we can update and refactor the CI, since MacOS 10.15 and Ubuntu 18.04 are both deprecated.

@chrysle chrysle changed the title Fix macos 11 tests Fix failing MacOS 11 tests Jun 30, 2023
GitHub runners for Ubuntu 18.04 and MacOS 10.15 are not available any longer.
Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I've also removed the deprecated platforms, as the corresponding jobs were never picked up by GitHub.

@inkarkat inkarkat merged commit c8fa5f1 into todotxt:master Jun 30, 2023
2 checks passed
@chrysle chrysle deleted the fix-macos-11-tests branch June 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants