Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openocd: finer-grained error msg if board unknown #108

Merged

Conversation

wprzytula
Copy link
Contributor

When trying to set up tockloader to use openocd, I kept getting the generic message saying "Could not determine the current board or arch or openocd board name". Not only did it not mention missing page_size parameter, but also was too coarse-grained. With splitting the error message, I managed to debug this, so I believe this could be beneficial to anyone.

Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

When trying to set up tockloader to use openocd, I kept getting
the generic message saying "Could not determine the current board
or arch or openocd board name". Not only did it not mention missing
page_size parameter, but also was too coarse-grained. With splitting
the error message, I managed to debug this, so I believe this could be
beneficial to anyone.
@wprzytula wprzytula force-pushed the finer-grained-unknown-board-error branch from 324ca5f to 4401776 Compare February 8, 2024 17:20
@wprzytula
Copy link
Contributor Author

Fixed missing colon.

@wprzytula
Copy link
Contributor Author

What's the status of this @lschuermann? When is this going to be merged?

@bradjc
Copy link
Contributor

bradjc commented Feb 29, 2024

Needs formatting.

@wprzytula
Copy link
Contributor Author

Formatting done, feel free to squash the new commit with the main one.

@lschuermann
Copy link
Member

GitHub Actions seems stuck right now at the "Cleaning orphan processes" step, let's wait a couple of minutes and see whether it gets resolved. The actual CI steps seem to pass though, so this should be good to go.

@lschuermann lschuermann merged commit 4119893 into tock:master Mar 1, 2024
2 checks passed
@wprzytula wprzytula deleted the finer-grained-unknown-board-error branch March 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants