Send a correct length of a query response #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown in examples in Section 5.3 from RFC 1205 [0] and Section 15-130 from SC30-3533-04 [1], Client should reply to a Write Structured Field command with Row/Column (2 bytes), AID Code (1 byte) and Structured Field. Structured Field should begin with Length (2 bytes; including the length bytes) followed by data specific to a command. Note that tn5250j already included the correct length in a comment but still sent 64 instead of 61. [0] https://datatracker.ietf.org/doc/html/rfc1205 [1] IBM. 5494 Remote Control Unit - Functions Reference. SC30-3533-04 Sponsored by: Fudo Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in examples in Section 5.3 from RFC 1205 [0] and Section 15-130 from SC30-3533-04 [1], Client should reply to a Write Structured Field command with Row/Column (2 bytes), AID Code (1 byte) and Structured Field. Structured Field should begin with Length (2 bytes; including the length bytes) followed by data specific to a command.
Note that tn5250j already included the correct length in a comment but still sent 64 instead of 61.
[0] https://datatracker.ietf.org/doc/html/rfc1205
[1] IBM. 5494 Remote Control Unit - Functions Reference. SC30-3533-04
Sponsored by: Fudo Security