Fix for screens transmitted over multiple packets #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some screens are transmitted over multiple packets. In particular more than one writeToDisplay commands to build up a full screen. Right now processSOH() calls clearTable() every time, even if the screen isn't cleared. This resets the fields, which means any input fields from the earlier packet are no longer seen as input fields. Any input to these fields results in a "Cancel Invite Operation" being sent to the host which responds with "Cursor in protected area of display." By simply commenting out this call to clearTable() and relying on the clearTable() call from clearAll() we avoid this problem, without breaking rendering or other field functions. This hasn't been heavily tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screens are transmitted over multiple packets. In particular more
than one writeToDisplay commands to build up a full screen. Right now
processSOH() calls clearTable() every time, even if the screen isn't
cleared. This resets the fields, which means any input fields from the
earlier packet are no longer seen as input fields. Any input to these
fields results in a "Cancel Invite Operation" being sent to the host
which responds with "Cursor in protected area of display."
By simply commenting out this call to clearTable() and relying on the
clearTable() call from clearAll() we avoid this problem, without
breaking rendering or other field functions.
This hasn't been heavily tested.