Third party integration #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libraries (terminaldriver)
Keylistener patch
…egration # Conflicts: # src/org/tn5250j/framework/tn5250/Screen5250.java
…e public interface for it additionally, a lot of re-formating and boy-scouting
|
I'd love to see this make it into trunk. |
|
@nitram509, could this be merged? Thanks! |
|
@cycloon is merging this an option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nitram
Looks good! I see you moved the methods towards the java bean convention (getter/setters).
This will work great for now please include it in the core.
Note: pasting text circumvents onCursorMoved() and onKeysSent() in ScreenListener, but we can address that in a future feature.