Fix Battery Percentage When Grep Colors Is Set(Zsh) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTSCode
changed the title
|
@martinbeentjes is there anything I need to do to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from bash to zsh on my Macbook the
battery_percentageoutput went from the normal%100to[1;35;40m[K100%[m[Kafter messing with it for a while I realized I had setGREP_OPTIONS='--color=always'in my.zshrcfile and zsh was setting that env var in the script being used to output the battery_percentage. So the output was being wrapped in grep colorization.This PR fixes the issue with grep attempting to colorize output for pmset by passing the option --color=never to the grep command in the battery percentage script.
*I realize that grep is used in many other places in this plugin but I don't have the resources to test all the other uses it's used at and am worried about breaking something by copying the change to all uses of grep without testing each one.