Introduce support for nested objects #455
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work, we encountered a case where we have contract classes (DTOs) containing another DTOs, being nested objects. It seemed that Flurl doesn't support this currently, while e.g. ASP.NET MVC model binder can correctly deserialize them from GET query parameters.
Hence the PR, introducing support for serializing nested object by composing property names using a dot.
By the way, I modified
can_set_timeout_and_cancellation_token
test to expectOperationCancelledException
instead ofTaskCancelledException
, because it simply wouldn't pass on my machine otherwise. I'm not entirely sure that's correct, but it seems reasonable sinceOperationCancelledException
is a base class and also represents cancellation.