Code Reuse scripts/test-tls13-post-handshake-auth.py #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Reuse Better comment Remove unused modules Code reduction Further reduce the code by making it go through the flow of the function
nrathaus
force-pushed
the
code-reuse-scripts-test-tls13-post-handshake-auth
branch
from
ae2f189
to
87bf82b
Compare
|
sorry for the delay in reviewing those PRs, but I'm extremely busy with Marvin Attack. I'm afraid that I won't be able to start reviewing them again till January. |
|
No problem, thank you for keeping me posted BTW: Marvin seems to be covered in : Is the Marvin you are referring to different from this? |
it's one and the same it's just that there's a bit of a fallout from it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce code complexity by making repeated code appear once inside a function
This change is