Various fixes around timing tests #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 3f67967 into c56a143 - view on LGTM.com new alerts:
|
tomato42
force-pushed
the
timing-fixes
branch
3 times, most recently
from
a4f6937
to
e251ac8
Compare
|
This pull request introduces 2 alerts when merging e251ac8 into ad0ec24 - view on LGTM.com new alerts:
|
tomato42
force-pushed
the
timing-fixes
branch
2 times, most recently
from
e711756
to
dcbaa84
Compare
t184256
reviewed
Jan 17, 2023
docs/source/timing-analysis.rst
Outdated
| dnf install -y python3 python3-devel tcpdump gmp-devel swig mpfr-devel \ | ||
| libmpc openssl-devel make gcc gcc-c++ git libmpc-devel python3-six \ | ||
| meson openblas-devel gcc-gfortran lapack-devel zlib-devel \ | ||
| libtiff-devel libjpeg-devel openjpeg2-devel zlib-devel freetype-devel \ |
There was a problem hiding this comment.
actually, given the complexity of getting them all installed, I'll probably provide both commands, as it affects only people running tests on platforms other than x86_64 and aarch64
tomato42
force-pushed
the
timing-fixes
branch
from
2019f53
to
4ac68d4
Compare
tomato42
force-pushed
the
timing-fixes
branch
from
2ecf808
to
a01bd27
Compare
tomato42
commented
Feb 18, 2023
tlsfuzzer/analysis.py
Outdated
| diff_stats["SD"] = np.std(diff) | ||
| quantiles = np.quantile(diff, [0.25, 0.5, 0.75]) | ||
| diff_stats["median"] = quantiles[1] | ||
| diff_stats["IQR"] = quantiles[2] - quantiles[1] |
|
@t184256 why did you push to this branch? |
|
By mistake. |
tomato42
force-pushed
the
timing-fixes
branch
2 times, most recently
from
ce91c3d
to
26e6932
Compare
tomato42
force-pushed
the
timing-fixes
branch
2 times, most recently
from
b370fdc
to
9454b60
Compare
tomato42
force-pushed
the
timing-fixes
branch
3 times, most recently
from
c7a7c38
to
c74809d
Compare
use to create a list of IDs from the legend file to allow analysis of raw_times_detail.csv based on probe ID include also the tuple ID for pairwise testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the timing tests more useful/usable/reliable
Motivation and Context
Better handling of timing tests
Obsoletes #728
Checklist
tlslite-ng.jsonandtlslite-ng-random-subset.jsonThis change is