native: scroller post loading #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnbrwstr
requested review from
patosullivan,
latter-bolden and
alecananian
and removed request for
patosullivan
dnbrwstr
changed the title
patosullivan
approved these changes
May 16, 2024
Co-authored-by: Patrick O'Sullivan <patrick@osullivan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements ""intelligent"" post loading in the scroller, which should allow us to initialize the scroller at any post and correctly load content before + after. In order to do that it implements windowing -- tracking which cached posts are contiguous so that we know whether there's a gap with missing posts.
It's still missing scroll-to-bottom, and scrolling to a post in history from inside the channel (clicking on a ref, or on a search result) isn't yet implemented. It may be slow or mushy in some situations -- further work should improve that.