Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negotiation: allow messaging awaiting status ships #3512

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

negotiation: allow messaging awaiting status ships #3512

wants to merge 1 commit into from

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented May 13, 2024 •
edited by jamesacklin

Fixes TLON-1638

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@jamesacklin
Copy link
Member

@arthyn Is this still WIP?

@linear Linear
Copy link

linear bot commented May 24, 2024

TLON-1638 Creating a DM with someone who doesn't have the same version of the app as I results in a broken/inaccessible DM

@arthyn arthyn marked this pull request as ready for review May 24, 2024 20:53
@arthyn
Copy link
Member Author

arthyn commented May 24, 2024

@jamesacklin no it's ready. this is maybe a controversial change? let me know what y'all think

@jamesacklin
Copy link
Member

How so? Let's chat Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patosullivan patosullivan patosullivan approved these changes

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

@Fang- Fang- Awaiting requested review from Fang-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arthyn @jamesacklin @patosullivan