native: create & join DMs and Groups #3507

latter-bolden · 2024-05-13T15:19:09Z

Adds support for:

displaying pending Groups & DMs in the chat list (invited, joining, requested)
adds GroupPreview sheet that displays the group meta and contains actions (request to join, accept invitation, etc.)
handles DM invites so when you click in you see what was sent and can either accept, deny, or deny & block the invite
an add sheet for groups where you can either create a new one or lookup groups by host
an add DM sheet where you can select ships to start a new DM with (blocks for group chats if there's a version mismatch)

Some of the sheet subcomponents could use more design attention and the ContactBook needs perf polish, but I don't want to hold this up any longer and those can be refined in a second pass. Focus here is on getting all the actions functional and the chat states correct.

Fixes LAND-1706
Fixes LAND-1859
Fixes LAND-1707
Fixes LAND-1735
Fixes LAND-1858
Fixes LAND-1910
Fixes LAND-1920

I Swear, I Really Wanted to Make a Reasonably Sized PR but This Is Literally the Way the Wind Blew Me This Time

…wo depending on if you selected contacts

…lay states for non-invite pending groups, refactor pending group model changes

linear · 2024-05-16T15:21:17Z

LAND-1706 native: create a group

LAND-1859 native: accept a group invitation

LAND-1735 native: start a DM

LAND-1707 native: join a group by searching for host

…group preview into placeholder join group flow, badges for requested groups

linear · 2024-05-17T14:01:57Z

LAND-1858 native: accept a DM request

…ccept, fix dms not dissapearing from the chat list after declining, fix stale clubs showing up if youre not a member or invited

… individual reusable widgets, compose sheet using native stack for mobile app

…adddmsheet post split

dnbrwstr

Few starters, still working through.

apps/tlon-web/vite.config.mts.timestamp-1715899052010-3592393101c17.mjs

apps/tlon-web/src/groups/GroupAdmin/PendingMemberItem.tsx

apps/tlon-mobile/src/screens/ChatListScreen.tsx

packages/ui/src/components/SelectableContactList.tsx

packages/ui/src/utils/channelUtils.tsx

packages/ui/src/components/SearchBar.tsx

packages/shared/src/api/urbit.ts

packages/shared/src/db/queries.ts

dnbrwstr

Few more assorted...

packages/shared/src/db/queries.ts

packages/shared/src/logic/utils.ts

packages/shared/src/debug.ts

packages/shared/src/db/queries.ts

packages/shared/src/api/groupsApi.ts

packages/shared/src/store/sync.ts

packages/ui/src/components/Channel/index.tsx

packages/ui/src/components/ContactBook.tsx

packages/ui/src/components/AddChats/AddDmSheet.tsx

packages/ui/src/components/ContactBook.tsx

packages/ui/src/hooks/contactSorters.ts

packages/shared/src/api/channelsApi.ts

packages/shared/src/api/chatApi.ts

packages/shared/src/db/types.ts

packages/shared/src/store/sync.test.ts

dnbrwstr

Looking good! Besides the few comments above, remaining stuff is:

Refactor api methods so we don't need to pass in current user
If there's anyway we can abstract the scroller managements stuff it'd be really nice, as it's kind of threaded through in a number of places

packages/ui/src/components/ContactRow.tsx

packages/ui/src/components/Badge.tsx

packages/ui/src/components/AddChats/ViewUserGroupsWidget.tsx

…an being passed in

…strictions

jamesacklin · 2024-05-23T15:16:48Z

Exciting stuff. Do we want an ephemeral build for this?

dnbrwstr

Code lgtm!

…oned, never drop metadata, fall back to parsing claim for group privacy if preview is missing from gang

linear · 2024-05-24T15:02:02Z

LAND-1910 native: requested group missing title, photo

linear · 2024-05-24T15:04:33Z

LAND-1920 native: branching new/join/DM button unusable

alecananian and others added 12 commits May 9, 2024 18:31

add group invitation accept/reject handler

0cd6ecf

Merge branch 'develop' into alec/land-1859-group-invite

0738509

add group preview to invite sheet

c3c079d

bring invites to top of list

555a253

subscribe to and handle groups updates

3a25176

native: add dm join/creation and group creation flows

af170a5

fix patp match checking in contact sort

7069766

clear sort test state

5059a7d

float create dm/group button to bottom of sheet, toggle between the t…

9925bdf

…wo depending on if you selected contacts

find groups for host, minimal join group placeholder flow

538eec7

Merge branch 'develop' into alec/land-1859-group-invite

8648490

rename inviteStatus to joinStatus

55e7351

alecananian mentioned this pull request May 15, 2024

native: add group invitations to chat list and handle accept/reject rsvps #3519

Closed

latter-bolden added 4 commits May 15, 2024 18:58

Merge branch 'alec/land-1859-group-invite' into lb/add-chats

5f3e1c4

Merge branch 'develop' into lb/add-chats

3e2e551

cosmos

8ab9c2d

fix gang handling, return pending groups in current chats query, disp…

60a011a

…lay states for non-invite pending groups, refactor pending group model changes

latter-bolden added 2 commits May 16, 2024 18:38

fix chat list typing, request/rescind invite, join/cancel join, pull …

d5f4a7f

…group preview into placeholder join group flow, badges for requested groups

accept, deny, deny + block dm & multidm invites

95b1f04

latter-bolden added 7 commits May 19, 2024 15:11

Merge branch 'develop' into lb/add-chats-b

bef4166

add live updates for club, fix dm invite buttons not clearing after a…

40fe8a2

…ccept, fix dms not dissapearing from the chat list after declining, fix stale clubs showing up if youre not a member or invited

split create/join group out into separate modal, move main content to…

b4d3458

… individual reusable widgets, compose sheet using native stack for mobile app

add contact book component to match figma, remove leftover code from …

ade8fa5

…adddmsheet post split

remove comment from sctionlist implementation

1675ddb

fix sheet state clearing on dismiss

cb342d4

remove unused context, actually reset dm selected on sheet close

556ace2

latter-bolden requested a review from dnbrwstr May 20, 2024 22:14

latter-bolden marked this pull request as ready for review May 20, 2024 22:14

comment

9a78da1

latter-bolden requested a review from patosullivan May 21, 2024 15:30

dnbrwstr reviewed May 21, 2024

View reviewed changes

latter-bolden added 2 commits May 21, 2024 13:57

fixes

5b43bc9

clear tracked poke watchers on full client reset

63394cc

dnbrwstr reviewed May 21, 2024

View reviewed changes

latter-bolden added 3 commits May 21, 2024 23:06

more fixes

6348c52

on group delete, cascade delete to child tables

1010b3a

fix add contact pinned group detection, subscribe to contact updates

946b66b

dnbrwstr reviewed May 22, 2024

View reviewed changes

latter-bolden added 4 commits May 22, 2024 13:57

fixes start coming and they dont stop coming

3d4e67c

less brittle group/channel type guards

8874469

Merge branch 'develop' into lb/add-chats

af00f78

whoops

99b5685

dnbrwstr requested changes May 22, 2024

View reviewed changes

packages/ui/src/components/ContactRow.tsx Outdated Show resolved Hide resolved

packages/ui/src/components/Badge.tsx Outdated Show resolved Hide resolved

packages/ui/src/components/AddChats/ViewUserGroupsWidget.tsx Outdated Show resolved Hide resolved

latter-bolden added 4 commits May 22, 2024 23:20

native: access current user id in api/store from the client rather th…

304f637

…an being passed in

critical one liner

a86936f

badge in author row and display name helper

b658ef9

native: get groups by user into hook, fix overzealous client proxy re…

535f925

…strictions

float group to top of list with new label after join/invite accept

ac56b1e

dnbrwstr approved these changes May 23, 2024

View reviewed changes

latter-bolden added 3 commits May 23, 2024 14:07

use table invalidations for contact hooks

0d9507c

only update conflicting unjioned group if the the target is also unji…

0593493

…oned, never drop metadata, fall back to parsing claim for group privacy if preview is missing from gang

Merge branch 'develop' into lb/add-chats

fa77e85

fix issue with insertChannels, add onConflictDoNothing() for chatMembers

545f395

latter-bolden merged commit 7e63488 into develop May 24, 2024
1 check failed

latter-bolden deleted the lb/add-chats branch May 24, 2024 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

native: create & join DMs and Groups #3507

native: create & join DMs and Groups #3507

latter-bolden commented May 13, 2024 •

edited by jamesacklin

linear bot commented May 16, 2024

linear bot commented May 17, 2024

dnbrwstr left a comment

dnbrwstr left a comment

dnbrwstr left a comment

jamesacklin commented May 23, 2024

dnbrwstr left a comment

linear bot commented May 24, 2024

linear bot commented May 24, 2024

native: create & join DMs and Groups #3507

native: create & join DMs and Groups #3507

Conversation

latter-bolden commented May 13, 2024 • edited by jamesacklin

linear bot commented May 16, 2024

linear bot commented May 17, 2024

dnbrwstr left a comment

Choose a reason for hiding this comment

dnbrwstr left a comment

Choose a reason for hiding this comment

dnbrwstr left a comment

Choose a reason for hiding this comment

jamesacklin commented May 23, 2024

dnbrwstr left a comment

Choose a reason for hiding this comment

linear bot commented May 24, 2024

linear bot commented May 24, 2024

latter-bolden commented May 13, 2024 •

edited by jamesacklin