Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: integrate with frontend #3388

Merged
merged 39 commits into from
May 20, 2024
Merged

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Apr 3, 2024

This fixes LAND-1516. In integrating with the frontend I found quite a few things that needed to change with our types. The main backend changes that happened were:

  • Fully fleshed out the source type and use that instead of the previous mix of source and *-concern types.
  • Made sure each source includes enough information to find the parent source so that we can do defaulting correctly
  • Add notified to events so we can track whether something was notified historically (which may be different from our current settings)
  • Changed volume settings to use a map instead of signifiers so that levels can be adjusted granularly. Allows us to move to a new default while migrating old users with the current default
  • Made unread-summary more generic so that it can be used nested/recursively
  • Cleaned up some of the more confusing type names

Frontend-wise:

  • Added new activity firehose subscription to track all activity events
  • Adjusted all unreads usage to use new activity agent data
  • Disconnected thread unreads from main window
  • Adjusted default unread color to be gray-400 and only show blue when there are unread/unseen notifications
  • Changed UnreadIndicator so it can be passed whether an unread has notifications
  • Adjusted volume setting to work with new map system

To do in another PR:

  • Allow notification settings for threads
  • Remove current "full-info" scry on frontend and wrap unreads into a new init scry
  • Add reaction events and any other event types we could conceive of
  • Integrate with activity feed
  • Show unread counts based on a setting?
  • Verify everything is in mark-warmer that needs to be

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

Targets #3354.

desk/app/activity.hoon Outdated Show resolved Hide resolved
Base automatically changed from m/activity-integrations to activity-release April 18, 2024 16:28
@arthyn arthyn changed the title (WIP) activity: integrate with frontend activity: integrate with frontend Apr 18, 2024
@arthyn arthyn marked this pull request as ready for review April 18, 2024 21:56
@arthyn
Copy link
Member Author

arthyn commented Apr 18, 2024

This is just for unread flow. Going to follow-up with notification volume/mutes, and updating unread flow to make threads and main window separate.

@arthyn arthyn changed the base branch from activity-release to develop May 3, 2024 18:01
@arthyn arthyn changed the base branch from develop to activity-release May 3, 2024 18:01
Copy link

linear bot commented May 8, 2024

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly good, just some nits on imports, errant console logs, etc.

apps/tlon-web/src/chat/ChatScroller/ChatScroller.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/components/VolumeSetting.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/components/VolumeSetting.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/dms/DMThread.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/dms/MessagesList.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/logic/useScrollerMessages.ts Outdated Show resolved Hide resolved
apps/tlon-web/src/replies/ReplyMessage.tsx Outdated Show resolved Hide resolved
apps/tlon-web/src/state/activity.ts Outdated Show resolved Hide resolved
apps/tlon-web/src/state/channel/channel.ts Outdated Show resolved Hide resolved
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed:

desk/sur/activity.hoon Outdated Show resolved Hide resolved
desk/sur/activity.hoon Outdated Show resolved Hide resolved
desk/sur/activity.hoon Outdated Show resolved Hide resolved
desk/sur/activity.hoon Outdated Show resolved Hide resolved
desk/sur/activity.hoon Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/activity.hoon Outdated Show resolved Hide resolved
desk/app/channels.hoon Outdated Show resolved Hide resolved
@Fang- Fang- self-requested a review May 16, 2024 15:46
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addressed all my feedback. Should be Fine Now™.

@arthyn arthyn merged commit d9846d1 into activity-release May 20, 2024
1 check failed
@arthyn arthyn deleted the hm/integrate-activity branch May 20, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants