-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activity: integrate with frontend #3388
Conversation
/indexed for per-concern stream querying, /each as equivalent to "all" but with count responses _per concern_ rather than in total.
…-apps into hm/integrate-activity
Wherever we would generate hark notifications we now also push to the activity agent.
activity: cleanup and clarify types
This is just for unread flow. Going to follow-up with notification volume/mutes, and updating unread flow to make threads and main window separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks mostly good, just some nits on imports, errant console logs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addressed all my feedback. Should be Fine Now™.
This fixes LAND-1516. In integrating with the frontend I found quite a few things that needed to change with our types. The main backend changes that happened were:
source
type and use that instead of the previous mix ofsource
and*-concern
types.notified
to events so we can track whether something was notified historically (which may be different from our current settings)unread-summary
more generic so that it can be used nested/recursivelyFrontend-wise:
gray-400
and only show blue when there are unread/unseen notificationsUnreadIndicator
so it can be passed whether an unread has notificationsTo do in another PR:
PR Checklist
Targets #3354.