scroller: use subset of messages from chat window #3346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage page size, memoize messages from useInfinitePosts to prevent unnecessary re-renders, use scrollElement height when we flip in the chat scroller
patosullivan
changed the title
|
Code makes sense. Banging on it locally, 1) I did hit an instance of a scroll loop in Internet Cafe and 2) got it to lock up where I was at the top of the scroll and older messages didn't load in despite there being more in the channel. Have to pivot off this for now, but will try to pinpoint specific steps to repro. |
|
@patosullivan were you able to repro what @latter-bolden saw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes LAND-1553 by forcing the scroller to invert/uninvert more often by only giving it a small set of already cached messages to start off with, and progressively adding messages as necessary (as the user scrolls up or down).
This should be ready for review/banging-on.