Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

487: twilio settings check for local build #489

Conversation

jaydonkrooss
Copy link
Contributor

@jaydonkrooss jaydonkrooss commented May 1, 2024

Skip over the initialization of Twilio client when the settings are not set locally, and add some helpful logs.

Test Plan:

  1. See if local build without Twilio settings runs properly
  2. Try running the app with test Twilio settings
  3. Verify that OTP texting service works with Twilio settings (this is what loads the notifications.py import)

@jaydonkrooss jaydonkrooss self-assigned this May 1, 2024
@jaydonkrooss jaydonkrooss requested review from jonespm and zqian May 1, 2024 18:42
@jaydonkrooss jaydonkrooss linked an issue May 2, 2024 that may be closed by this pull request
src/officehours_api/notifications.py Outdated Show resolved Hide resolved
src/officehours_api/notifications.py Outdated Show resolved Hide resolved
src/officehours_api/notifications.py Outdated Show resolved Hide resolved
@jaydonkrooss jaydonkrooss merged commit 5172b78 into tl-its-umich-edu:master May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Twilio requirement for local build
2 participants