changes to issue #1558 regarding failed Jest test cases #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zqian
changed the title
pushyamig
reviewed
Apr 26, 2024
| @@ -1,4 +1,4 @@ | |||
| import * as d3 from 'd3' | |||
| import * as d3 from 'd3/dist/d3.min' | |||
There was a problem hiding this comment.
I don't feel we import things from dist folder. This change effects the View. why are you doing this?
There was a problem hiding this comment.
None of the imports in the project we use dist in path while importing. This needs to be changed.
pushyamig
reviewed
Apr 26, 2024
| ["@babel/preset-react",{"runtime": "automatic"}]] | ||
| [ | ||
| "@babel/preset-env", | ||
| { |
There was a problem hiding this comment.
I would like to keep this format same as before. What was the reason for re-formatting this?
pushyamig
reviewed
Apr 26, 2024
| @@ -7,7 +7,7 @@ const mylaGlobals = mylaGlobalsEl ? JSON.parse(mylaGlobalsEl.textContent) : {} | |||
|
|
|||
| let cspNonce | |||
| const cspMetaEl = document.querySelector('meta[name="csp-nonce"]') | |||
| if (cspMetaEl !== null & cspMetaEl.hasAttribute('content')) { | |||
| if (cspMetaEl !== null && cspMetaEl.hasAttribute('content')) { | |||
There was a problem hiding this comment.
Undo the change here as I don't feel this needed any change
pushyamig
reviewed
Apr 26, 2024
| // // The output is always the same. | ||
| // return 'cssTransform'; | ||
| // } | ||
| // }; |
There was a problem hiding this comment.
You should always remove commented code , if not used
|
Can you email me or share your Uniqname? we are keeping track of students from EECS course who are contributing to our repo |
pushyamig
requested changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to make all the tests work by rewriting the CSSTransform file and updating the Jest version in package.json (this can also be done by running
npm update jest. I used babelnpm install babel-jest --save-devto reconfigure some files, as I believe that was causing some of the tests to fail. The main goal was to configure Jest for ECMAScript Modules, as the issue came from trying to import d3 using ECMAScript Module syntax (import * as d3 from 'd3') in the Histogram test. Using the minified version of d3 resolved this issue. In addition to updating snapshots before running backend tests, I was able to compile all the tests successfully.