Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of attributes in hooks #485

Merged
merged 2 commits into from Nov 14, 2020
Merged

Allow usage of attributes in hooks #485

merged 2 commits into from Nov 14, 2020

Conversation

kp42
Copy link
Contributor

@kp42 kp42 commented Nov 9, 2020

Pass the attributes object to skipLazyLoading and isBot so that the lazy loading can be toggle on per image basis.

Fixes #483

@tjoskar
Copy link
Owner

tjoskar commented Nov 14, 2020

Thanks @kp42,
I hope we get override in the next TS version so these kinds of errors won't happen again.

@tjoskar tjoskar merged commit ddefb33 into tjoskar:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntersectionObserverHooks has wrong definition of skipLazyLoading method
2 participants