Created functions to control css class names #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjoskar
reviewed
Jan 21, 2018
|
|
||
| export function hasCssClassName(element: HTMLImageElement | HTMLDivElement, cssClassName: string) { | ||
| return element.className && element.className.includes(cssClassName); | ||
| } |
There was a problem hiding this comment.
Even though these functions are quite simple, it should be nice to add some unit tests.
There was a problem hiding this comment.
We do not need to test replace and includes but the code has logic that checks if className is defined and that line 11 only should run if cssClassName don't exist.
|
Thanks @rimlin, can you add a few test case for the code? |
|
@tjoskar yes, will add tests at this week. |
|
Added tests. |
|
Ref: #270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created functions to manage css class names