Remove Ion.egg-info and build_sources.sh #1669
Open
+3
−3,978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnans2006
force-pushed
the
pyproject-migration
branch
2 times, most recently
from
0483844
to
012d190
Compare
Python eggs are no longer supported: they have been entirely replaced by wheels. Therefore, carrying around an `Ion.egg-info` and having to build sources is highly unnecessary.
krishnans2006
force-pushed
the
pyproject-migration
branch
from
012d190
to
6b203d3
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ion.egg-infobuild_sources.shobsolete, and remove any references to it in other scripts and CIBrief description of rationale
Python eggs are no longer supported: they have been entirely replaced by wheels (see here, here, and here). Therefore, carrying around an
Ion.egg-infoand having to build sources is highly unnecessary.Below is a (truncated) successful installation of
intranetas a pip package, withoutIon.egg-info:This change is made possible by #1648.