Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polls): add randomization option #1540

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat(polls): add randomization option #1540

wants to merge 1 commit into from

Conversation

disco-io
Copy link
Contributor

@disco-io disco-io commented May 7, 2023

Proposed changes

  • Add a randomization checkmark feature to polls

Brief description of rationale

  • Ensures fairness of voting

Closes #1526

@disco-io disco-io requested review from a team and shahsalonik as code owners May 7, 2023 18:51
@coveralls
Copy link

Coverage Status

Coverage: 81.259% (-0.02%) from 81.279% when pulling 604a48e on disco-io:poll-commit into 7cc4dcb on tjcsl:dev.

@ksquaring
Copy link
Contributor

LGTM! @alanzhu0 check

alanzhu0
alanzhu0 requested changes May 8, 2023
View reviewed changes
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Could you make it so questions can be individually randomized as we discussed?

shahsalonik
shahsalonik requested changes May 12, 2023
View reviewed changes
Copy link
Contributor

@shahsalonik shahsalonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add in Alan's changes? Thanks!

@disco-io
Copy link
Contributor Author

Yes! I will work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahsalonik shahsalonik shahsalonik requested changes

@alanzhu0 alanzhu0 alanzhu0 requested changes

@NotFish232 NotFish232 Awaiting requested review from NotFish232

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@disco-io @coveralls @ksquaring @shahsalonik @alanzhu0