Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep: root, docs, tests의 패키지 업데이트 #797

Merged
merged 1 commit into from Jun 11, 2020
Merged

Conversation

giwan-dev
Copy link
Contributor

@giwan-dev giwan-dev commented Jun 11, 2020

설명

root, docs, tests의 패키지를 업데이트합니다.

변경 내역 및 배경

test 패키지 빌드할 때 발생하는 에러를 확인해보니 오래된 바벨 패키지에서 발생하는 것으로 보였습니다. storybookjs/storybook#10477
그래서 root, docs, tests 디렉토리에서 npm update 돌려줬습니다.

사용 및 테스트 방법

CI..

이 PR의 유형

  • 버그 또는 사소한 수정

test 패키지 빌드할 때 발생하는 에러를 확인해보니 오래된 바벨 패키지에서 발생하는 것으로 보였습니다.
storybookjs/storybook#10477
@giwan-dev giwan-dev requested a review from a team as a code owner June 11, 2020 02:32
@giwan-dev giwan-dev added this to the v1.24.0 milestone Jun 11, 2020
Copy link
Contributor

@appear appear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오홍 ,,,

@appear appear requested a review from a team June 11, 2020 04:52
Copy link
Contributor

@rhiokim rhiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모듈 minor 업뎃이 많은데 큰 이슈 없나보균요. 👍

@giwan-dev
Copy link
Contributor Author

@rhiokim 앗... 일단 test랑 스토리북 여는 것 까지는 괜찮았는데 스토리북 좀 더 살펴보겠습니다....

@giwan-dev
Copy link
Contributor Author

음 devDependency가 바뀐 거니 빌드만 잘 되면 문제 없을거라고 봐도 되는 걸까요..?

@giwan-dev
Copy link
Contributor Author

일단은 큰 문제 없는 것 같습니다!

@giwan-dev giwan-dev merged commit b9c8ce7 into master Jun 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/update-babel branch June 11, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants