TINY-10794: Remove role="listbox" attribute from dropdowns #9571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpyder
reviewed
Apr 23, 2024
| @@ -245,7 +245,7 @@ const makeSandbox = ( | |||
| // TODO: Add aria-selected attribute | |||
| attributes: { | |||
| id: ariaControls.id, | |||
| role: 'listbox' | |||
| ...detail.role?.fold( Fun.constant({}), (role) => ({ role })) ?? {} | |||
There was a problem hiding this comment.
Why do we have an optional field with an Optional value 🤦
please either make the field mandatory or the value unwrapped.
If there's really no other way... you can actually spread undefined. It feels dirty though.
Suggested change
| ...detail.role?.fold( Fun.constant({}), (role) => ({ role })) ?? {} | |
| ...detail.role?.map((role) => ({ role })).getOr({}) |
|
Closed due the changes are incorporated in the other PR #9665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-10794
Description of Changes:
role="listbox"from dropdownsPre-checks:
feature/,hotfix/orspike/Review:
GitHub issues (if applicable):