Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse self-contained subgraphs #4463

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Qazalin
Copy link
Collaborator

@Qazalin Qazalin commented May 6, 2024

  • Detect self-contained subgraphs
  • Delete forced_realize

@Qazalin Qazalin force-pushed the overwrite-forced-realized branch from 023f25a to 2ed4360 Compare May 7, 2024 12:18
@Qazalin Qazalin changed the title test: overwrite forced_realize fusion rewrite start May 7, 2024
@geohot
Copy link
Collaborator

geohot commented May 8, 2024

Can you comment this better? I think it might help while thinking about it too.

@Qazalin
Copy link
Collaborator Author

Qazalin commented May 8, 2024

status: making progress on completing the logic for _can_localize

# is r + rest is a self-contained DAG within the large graph?
def _can_localize(r:LazyBuffer, *rest:LazyBuffer) -> bool

I plan to finish the spec and benchmark new fusion end-to-end.

@Qazalin Qazalin force-pushed the overwrite-forced-realized branch from d389931 to 6d398d9 Compare May 10, 2024 17:29
Copy link
Contributor

Changes

Name                           Lines    Diff    Tokens/Line    Diff
---------------------------  -------  ------  -------------  ------
tinygrad/engine/schedule.py      244     +17           14.0    -0.2


total lines changes: +17

@Qazalin Qazalin changed the title fusion rewrite start fuse self-contained subgraphs May 10, 2024
@Qazalin Qazalin mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants