Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix abs of diff of uint #4411

Merged
merged 1 commit into from May 15, 2024
Merged

fix abs of diff of uint #4411

merged 1 commit into from May 15, 2024

Conversation

chenyuxyz
Copy link
Collaborator

brought up in #4188
abs to unsigned or bool is no-op
use where for int because cstyle does not like relu for int (might have more issue with int in general)
keep double relu for float, would need to check perf before switching

RHIP crashed in CI @Qazalin fyi

Copy link
Contributor

Changes

Name                  Lines    Diff    Tokens/Line    Diff
------------------  -------  ------  -------------  ------
tinygrad/tensor.py      799      +3           21.7    -0.0


total lines changes: +3

@chenyuxyz chenyuxyz marked this pull request as ready for review May 15, 2024 22:37
@chenyuxyz
Copy link
Collaborator Author

fixed by the new abs #4611

@chenyuxyz chenyuxyz merged commit 04f2327 into tinygrad:master May 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant